-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pocket Integration #127
base: master
Are you sure you want to change the base?
Pocket Integration #127
Conversation
Can you provide the commands you're using to build? Running integration tests in Xcode gives me:
I also have some failures in PocketNetwork unit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to contribute to TezosKit. This PR overall looks great.
Here are a few notes that I think will help this integration remain easy to maintain and make it easy for clients to use. I don't feel incredibly strongly about these things, and I'm happy to take this PR as is if you'd rather not implement.
If you'd like, I'd be supportive of you adding an extension to TezosNodeClient
to automatically make a NodeClient with the Pocket network attached. You could place in /Pocket/TezosNodeClient+Pocket
and implement with:
extension PocketNetworkClient {
public static pocketNetworkNodeClient() -> PocketNetworkClient {
let pocketNEtworkClient = PocketNetworkClient(...)
return new TezosNodeClient(networkClient: pocketNetworkClient, ....)
}
}
(You could also use a convenience initializer if you prefer to the static factory method.
If you'd like to have integration tests, you can feel free to add them. I run integration tests manually on merge.
Here are the commands and resulting log files:Unit Tests:
Output: https://gist.github.com/keefertaylor/717bbea39a9e788e049da0397019953f Integration Tests: $ set -o pipefail && xcodebuild test -scheme IntegrationTests -destination 'platform=iOS Simulator,name=iPhone 8,OS=13.0' ONLY_ACTIVE_ARCH=YES | xcpretty Output: https://gist.github.com/keefertaylor/c4db31c1b82b535476064afd08ed491c |
…orkClient as per PR
Run `pod lib lint` in addition to Carthage
Update homebrew and install Carthage / CocoaPods if needed
# Conflicts: # Cartfile # Cartfile.resolved # TezosKit.podspec
Includes:
PocketNetworkClient: Public class that conforms to the NetworkClient protocol, adding the necessary steps and information to interact with the Pocket Network.
Carthage dependency: Added pocket-swift-core-carthage to the carfile, necessary to use all the core functionalities for Pocket.
Updated Project: Added necessary frameworks to the carthage script section and to the test target copy files to properly run the tests.