This repository has been archived by the owner on May 22, 2023. It is now read-only.
CI job for Celo client #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we introduce the `build-and-test` job for Celo. It's structure is almost identical than the existing `build-and-test` job for Ethereum. Both jobs are placed in separate `client-celo.yml` and `client-ethereum.yml` files. This is done in the sake of readability and allows easily grouping jobs under appropriate namespace (Go / Celo and Go / Ethereum). Regarding differences, the Celo job introduces additional build args (CHAIN=celo) while building Docker image and runs client tests with `celo` build tag. Also, cache names in both jobs are intentionally differentiated to completely separate them as `actions/cache` action sets the cache scope to the key and branch. Something similar refers to the intermediary `go-build-env` images. They now have chain specific suffixes to avoid problems while pushing them to local repo or cache in the future.
Without that test result files are overwritten by concurrent jobs.
This is needed because we use double dash to set build tags so positional arguments are taken into account by the `gotestsum` command and the default test command is not used in that case.
This reverts commit 7b0055e
nkuba
suggested changes
Mar 4, 2021
.github/workflows/client-celo.yml
Outdated
Comment on lines
7
to
9
| pull_request: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
We can remove the filter and run iyt on all PRs.
Suggested change
| pull_request: | |
| branches: | |
| - master | |
| pull_request: |
There was a problem hiding this comment.
Please see: 03aafa3
michalinacienciala
suggested changes
Mar 4, 2021
Also, got rid of chain-specific suffixes from test results directories and files.
|
@michalinacienciala all comments addressed! |
nkuba
previously approved these changes
Mar 5, 2021
# Conflicts: # .github/workflows/client-ethereum.yml
lukasz-zimnoch
force-pushed
the
celo-ci-jobs
branch
from
0db0257
to
4287e7f
Compare
nkuba
approved these changes
Mar 5, 2021
| # VERSION= ? TODO: Configure version, sample: 1.7.6 | ||
| push: | | ||
| ${{ startsWith(github.ref, 'refs/heads/releases/alfajores') }} |
There was a problem hiding this comment.
We could simplify branch name check with:
${{ startsWith(github.head_ref, 'releases/alfajores') }}
But it's something that I'd not block this PR with.
|
LGTM leaving final approval to @michalinacienciala |
michalinacienciala
approved these changes
Mar 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #710
Here we introduce the
build-test-publishjob for Celo. Its structure is almost identical than the existingbuild-test-publishjob for Ethereum. Both jobs are now placed in separateclient-celo.ymlandclient-ethereum.ymlfiles. This is done in the sake of readability and allows easily grouping jobs under an appropriate namespace (Go / CeloandGo / Ethereum).Regarding differences, the Celo job introduces additional build args (
HOST_CHAIN=celo) while building Docker image and runsclient tests with
celobuild tag. Also, cache names in both jobs are intentionally differentiated to completely separate them asactions/cacheaction sets the cache scope to the key and branch. Something similar refers to the intermediarygo-build-envimages. They now have chain-specific suffixes to avoid problems while pushing them to local repo or cache in the future.There is also a problem with reporting test results. @michalinacienciala noted a known bug (EnricoMi/publish-unit-test-result-action#12) in
EnricoMi/publish-unit-test-result-action@v1action we use to report test results. Because of that bug, it might happen that the test result summary will be under the wrong workflow while being presented in the PR summary. We're dropping the test results publishing step until the aforementioned bug gets resolved by the action maintainer.