This repository has been archived by the owner on May 22, 2023. It is now read-only.
Move publishing of Go client to GH Actions #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in RFC-18, there is a need for a refactorization of Keep and tBTC release processes in order to reduce human involvment and make the processes faster and less error prone. A part of this task is migration from CircleCI jobs to GitHub Actions. This commit enhances the GitHub Action `client.yml` workflow with step that publishes built docker image to `keep-test` Google Container Registry.
…-publish-go-client
nkuba
suggested changes
Mar 4, 2021
.github/workflows/client.yml
Outdated
Comment on lines
47
to
48
| REVISION=${{ github.sha }} | ||
| # VERSION= ? TODO: Configure version, sample: 1.7.6 |
There was a problem hiding this comment.
Actually, we don't need to configure REVISION and VERSION args for go-build-env image. We need to move it to the Build and publish Docker Runtime Image step.
There was a problem hiding this comment.
See 9fe8814
As mentioned by @nkuba in #715 (comment), we need `REVISION` and `VERSION` arguments to be configured not for the `go-build-env` image, but for the final image built in ` Build and publish Docker Runtime Image` step.
We are no longer using EnricoMi/publish-unit-test-result-action for publishing of tests results, due to a known bug in the action, causing wrong association of tests results with workflows (EnricoMi/publish-unit-test-result-action#12). Failing tests still will cause the job to be reported as failed.
|
Apart from doing changes related to publishing of client, I also got rid of the step that publishes the test results (in commit fc96d56). The step was sometimes causing wrong association between Test Results check and the workflows (due to a known bug: EnricoMi/publish-unit-test-result-action#12). |
nkuba
approved these changes
Mar 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in RFC-18, there is a need for a refactorization of Keep
and tBTC release processes in order to reduce human involvment and make
the processes faster and less error prone. A part of this task is
migration from CircleCI jobs to GitHub Actions. This commit enhances the
GitHub Action
client.ymlworkflow with step that publishes builtdocker image to
keep-testGoogle Container Registry.