Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update newsfeed + metadata #427

Merged
merged 11 commits into from
Aug 28, 2024
Merged

Update newsfeed + metadata #427

merged 11 commits into from
Aug 28, 2024

Conversation

alsoknownaslj
Copy link
Contributor

Changes

  • Updated Latest News to include the most recent posts
  • Changed cards to display the post's meta description vs. unformatted first lines of the post (looked messy/confusing because it included headers)
  • Cleaned up meta descriptions for all English posts
  • More extensive cleanup/optimization on three featured posts
  • Added description to index.md to fix Google search results metadata

Copy link

Preview uploaded to https://preview.tbtc.network/update-newsfeed/.

Copy link

Preview uploaded to https://preview.tbtc.network/update-newsfeed/.

Copy link
Member

@mhluongo mhluongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few open questions about content here

src/templates/home-page.js Outdated Show resolved Hide resolved
@@ -1,17 +1,26 @@
---
template: news-item
title: A tale of two bugs
description: The FTX exploit attempted redemption of tBTC revealed two bugs.
title: "A Tale of Two Bugs: Uncovering Vulnerabilities in tBTC Amid the FTX Exploit"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the subtitles directly in the interface are hard to read... death by a thousand colons.

Can we achieve what you want here (indexing benefit) without making the pieces so hard to read?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the repetition of phrases in H1 text is the key. can we shorten instead? kw to retain is "tBTC" and IMO "FTX exploit"

What about "A Tale of Two Bugs: tBTC and the FTX Exploit"

Copy link
Contributor

@Shadowfiend Shadowfiend Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine—though it's still a touch much:

Screenshot 2024-08-28 at 14 59 11

Perhaps in that scenario we kill the first heading in the post?

src/pages/news/2024-04-15-a-tale-of-two-bugs.md Outdated Show resolved Hide resolved
As has been reported this week, an address associated with the FTX exploit has been moving funds through a number of cross-chain projects.

While most of the funds have [gone through Thorchain](https://www.theblock.co/post/255108/thorswap-dex-enters-maintenance-mode-amid-illicit-activity?ref=blog.threshold.network), some of them have been routed through tBTC. In the process, two bugs have been exposed.

Neither bug puts user funds at risk. The first was patched and released yesterday, while the second requires community discussion and consensus.

## The first bug — a denial-of-service vector
### The First Bug: A Denial-of-Service Vector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to editorialize all of these titles, or do you just hate my originals? 😛

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't modify at all here, this is a replica.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to editorialize all of these titles, or do you just hate my originals? 😛

truly? i just hate it 🤣 i think we should standardize titles and subtitle letter case across the board. it's neater.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not on cross-posts, not today :)

Copy link

Preview uploaded to https://preview.tbtc.network/update-newsfeed/.

Copy link

Preview uploaded to https://preview.tbtc.network/update-newsfeed/.

@@ -1,6 +1,6 @@
---
template: news-item
title: "tBTC is for L2s: The Trust-Minimized Bitcoin Bridge for Layer 2 Scaling"
title: "tBTC is for L2s: A Bitcoin Bridge Built for Scaling"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Built to Scale” maybe?

Also wondering about dropping the first header below as well.

@@ -13,15 +13,15 @@ tags:
- DeFi
- Layer 2
---
## The Evolution of tBTC: A Decentralized Bitcoin Bridge
## Four Years of Bridging Bitcoin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, wondering if we drop this inner header.

@Shadowfiend Shadowfiend dismissed mhluongo’s stale review August 28, 2024 19:53

Yea verily the changes were made (for the most part).

Copy link

Preview uploaded to https://preview.tbtc.network/update-newsfeed/.

@Shadowfiend Shadowfiend merged commit 74f8063 into main Aug 28, 2024
1 check passed
@Shadowfiend Shadowfiend deleted the update-newsfeed branch August 28, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants