Add a version check on apps - Done #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, i have resolve the conflicts and now it is ready for merging, please do give it a final review and let me know if there is any further changes necessary, thanks! |
src/renderer/features/nodeSlice.ts
Outdated
Comment on lines
126
to
132
| const runningApps = useAppSelector(selectRunningApps); | ||
|
|
||
| // Terminate all currently running apps | ||
| Object.keys(runningApps).forEach((appId) => { | ||
| window.electron.ipcRenderer.madaraApp.stopApp(appId); | ||
| }); | ||
|
|
There was a problem hiding this comment.
why are we adding this?
There was a problem hiding this comment.
sorry its a missed unresolved comflict from the previous, i have fixed it already
apoorvsadana
merged commit a6c9bce
into
keep-starknet-strange:main
2 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.