Parse Schnorr Pub Key & Implement TaprootSigVerifierImpl::new #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
supreme2580
commented
Oct 19, 2024
supreme2580
commented
- issue #
- follows contribution guide
- code change includes tests
- parse_schnorr_pub_key : uses the reference from btcd https://github.com/btcsuite/btcd/blob/master/btcec/schnorr/pubkey.go#L23
- TaprootSigVerifierImpl::new: uses the reference from btcd https://github.com/btcsuite/btcd/blob/24eb815168f49dea84767817717a11bd7928eb23/txscript/sigvalidate.go#L313
|
@supreme2580 is attempting to deploy a commit to the keep-starknet-strange Team on Vercel. A member of the Team first needs to authorize it. |
|
It would be wise to make your PR against #225 or merge the PR feat:Taproot into main before? @b-j-roberts |
|
@Jeanmichel7 do you mean I should pull from feat:Taproot into my own branch? |
No, instead, make the pull request from your branch to the feat/taproot branch, since TaprootSigVerifier already has the structures. |
|
Ohhh I see... thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.