Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: P2SH #268

Merged
merged 5 commits into from
Oct 29, 2024
Merged

feat: P2SH #268

merged 5 commits into from
Oct 29, 2024

Conversation

varun-doshi
Copy link
Contributor

Run the tests using the following command:

scarb test -vv -p shinigami_tests -f test_p2sh_transaction_1

for 1...5

Test 4 fails to deserialize. Figuring this out

@vercel Vercel
Copy link

vercel bot commented Oct 21, 2024

@varun-doshi is attempting to deploy a commit to the keep-starknet-strange Team on Vercel.

A member of the Team first needs to authorize it.

b-j-roberts
b-j-roberts approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@b-j-roberts b-j-roberts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I'm going to mark p2sh test 4 as ignored for now, and we can get it to work in a separate PR. Thank you!

@b-j-roberts b-j-roberts merged commit 33c8024 into keep-starknet-strange:main Oct 29, 2024
3 of 4 checks passed
@b-j-roberts b-j-roberts mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-j-roberts b-j-roberts b-j-roberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varun-doshi @b-j-roberts