Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where pressing home on empty tag field crashes the program. #11346

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
+438 −363
Open

Fix bug where pressing home on empty tag field crashes the program. #11346

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7d48a7b
Fix bug where pressing home on empty tag field crashes the program.
libklein Oct 10, 2024
f980707
Move completer to TagsEdit.
libklein Oct 19, 2024
04442b3
Move paint implementation to impl.
libklein Oct 19, 2024
aaa56ba
Move cursor blink status to TagsEdit.
libklein Oct 19, 2024
c22154f
Hide editing_index and cursor position.
libklein Oct 27, 2024
4900da1
Hide remaining TextEdit internal fields.
libklein Oct 27, 2024
5ba6d2d
Refactor to use QLinkedList.
libklein Nov 5, 2024
03f12bc
Encapsulate tags and selected index in tags manager.
libklein Nov 5, 2024
0190def
Simplify calcRect and drawTag.
libklein Nov 10, 2024
ae07561
Remove obsolete EmptyTagIterator.
libklein Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/gui/tag/TagsEdit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ struct TagsEdit::Impl
assert(i < tags.size());
auto occurrencesOfCurrentText =
std::count_if(tags.cbegin(), tags.cend(), [this](const auto& tag) { return tag.text == currentText(); });
if (currentText().isEmpty() || occurrencesOfCurrentText > 1) {
if ((currentText().isEmpty() && tags.size() > 1) || occurrencesOfCurrentText > 1) {
tags.erase(std::next(tags.begin(), std::ptrdiff_t(editing_index)));
libklein marked this conversation as resolved.
Show resolved Hide resolved
if (editing_index <= i) { // Do we shift positions after `i`?
--i;
Expand Down