Add support to compress database using zstd algorithm #11498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the original private class of QtIOCompressor more algorithm orthogonal. Zlib details are now moved to a dedicated derived private class that implements the interfaces. With this, new algorithms can be added by similar way.
TOCK-Chiu
force-pushed
the
feature/zstd-compression
branch
from
8f311ae to
cf52387
Compare
|
This is not in the kdbx4 standard and we will not support it. Large databases like this are also an anti pattern. Use cryptomator to store large files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support to compress database using zstd algorithm. Zstd usually provides faster compression/decompression speeds and often provides better compression as well for large databases. In my rough test, gzip took around 4 seconds to compress a large database (which contains a 100 MB enwiki8 attachment), while zstd took around 1 second. The zstd-compressed database file is also 2.6% smaller (35,588,971 bytes vs 36,553,374 bytes).
Screenshots
Testing strategy
Added unit test. The database file
tests/data/Format410ZstdCompressed.kdbxused in unit test was manually edited fromtests/data/Format400.kdbx.Type of change