Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): dark mode detection #2739

Merged
merged 8 commits into from
Dec 4, 2024
Merged

feat(ui): dark mode detection #2739

merged 8 commits into from
Dec 4, 2024

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented Dec 3, 2024

Closes #2592

Before:

before.mov

After:

after.mov

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 3, 2024
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Dec 4, 2024 8:21am

@dosubot dosubot bot added Feature A new feature UI User interface related issues labels Dec 3, 2024
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm i guess!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.10%. Comparing base (451b8a1) to head (eb5ccce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2739       +/-   ##
===========================================
- Coverage   44.08%   31.10%   -12.98%     
===========================================
  Files         158       67       -91     
  Lines       15034     7400     -7634     
===========================================
- Hits         6628     2302     -4326     
+ Misses       8406     5098     -3308     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kiryous Kiryous merged commit 90f89ab into main Dec 4, 2024
12 checks passed
@Kiryous Kiryous deleted the feat/2592-dark-mode-detection branch December 4, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Match the dark-mode system state
2 participants