Skip to content

Conversation

diegovb-sys
Copy link
Contributor

Closes #5325

📑 Description

The current implementation doesn't seem to cover the idea behind the last resolved and first resolved. Moreover, based on a Postgres environment there is a Warning/Error because of the use of HAVING/GROUP_BY

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Copy link

vercel bot commented Sep 29, 2025

@diegovb-sys is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. Bug Something isn't working labels Sep 29, 2025
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 30, 2025
Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
keep Ready Ready Preview Comment Sep 30, 2025 5:01am

Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.52%. Comparing base (57ca737) to head (3d9346d).
⚠️ Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/core/db.py 0.00% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5338       +/-   ##
===========================================
- Coverage   46.64%   30.52%   -16.13%     
===========================================
  Files         175      101       -74     
  Lines       18263    11680     -6583     
===========================================
- Hits         8519     3565     -4954     
+ Misses       9744     8115     -1629     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Resolve ON - Incidents

2 participants