Skip to content

fix: Include the pusher flow in maintenance window #5360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Include the pusher flow in maintenance window #5360

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9df76d4
Include the pusher flow in maintenance window
diegovb-sys Oct 9, 2025
387fcb8
Merge branch 'main' into fix_complete_pusher_process
diegovb-sys Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 29 additions & 13 deletions keep/api/bl/maintenance_windows_bl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,11 +255,10 @@ def recover_strategy(
"tenant_id": tenant,
},
)

incidents = []
with tracer.start_as_current_span("mw_recover_strategy_run_rules_engine"):
# Now we need to run the rules engine
if KEEP_CORRELATION_ENABLED:
incidents = []
try:
rules_engine = RulesEngine(tenant_id=tenant)
# handle incidents, also handle workflow execution as
Expand All @@ -275,17 +274,34 @@ def recover_strategy(
"tenant_id": tenant,
},
)
pusher_cache = get_notification_cache()
if incidents and pusher_cache.should_notify(tenant, "incident-change"):
pusher_client = get_pusher_client()
try:
pusher_client.trigger(
f"private-{tenant}",
"incident-change",
{},
)
except Exception:
logger.exception("Failed to tell the client to pull incidents")

with tracer.start_as_current_span("mw_recover_strategy_notify_client"):
pusher_client = get_pusher_client()
if not pusher_client:
return
pusher_cache = get_notification_cache()
if pusher_cache.should_notify(tenant, "poll-alerts"):
try:
pusher_client.trigger(
f"private-{tenant}",
"poll-alerts",
"{}",
)
logger.info("Told client to poll alerts")
except Exception:
logger.exception("Failed to tell client to poll alerts")
pass

if incidents and pusher_cache.should_notify(tenant, "incident-change"):
pusher_client = get_pusher_client()
try:
pusher_client.trigger(
f"private-{tenant}",
"incident-change",
{},
)
except Exception:
logger.exception("Failed to tell the client to pull incidents")

try:
presets = get_all_presets_dtos(tenant)
Expand Down
Loading