add docker login action (#354)

* add docker login action Signed-off-by: sbadiger <[email protected]> * Update .github/workflows/ci.yaml Co-authored-by: Venkata Gunapati <[email protected]> Signed-off-by: sbadiger <[email protected]> * fix indetation Signed-off-by: sbadiger <[email protected]> --------- Signed-off-by: sbadiger <[email protected]> Co-authored-by: Venkata Gunapati <[email protected]>
keikoproj · Jul 14, 2023 · 204f08a · 204f08a
1 parent 952b2df
commit 204f08a
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -49,17 +49,24 @@ jobs:
         flags: unittests # optional
         name: codecov-umbrella # optional
         fail_ci_if_error: true # optional (default = false)
+
+    - name: Docker build
+      if: github.event_name == 'pull_request' || (github.repository != 'keikoproj/upgrade-manager' && github.event_name == 'push')
+      run: make docker-build
 
     - name: Set up Docker Buildx
       if: (github.event_name == 'push' || github.event_name == 'release') && github.repository == 'keikoproj/upgrade-manager'
       id: buildx
       uses: docker/setup-buildx-action@v2
       with:
         install: true
-
-    - name: Docker build
-      if: github.event_name == 'pull_request' || (github.repository != 'keikoproj/upgrade-manager' && github.event_name == 'push')
-      run: make docker-build
+
+    - name: Login to DockerHub
+      if: (github.event_name == 'push' || github.event_name == 'release') && github.repository == 'keikoproj/upgrade-manager'
+      uses: docker/login-action@v2
+      with:
+        username: ${{ secrets.DOCKER_USERNAME }}
+        password: ${{ secrets.DOCKER_PASSWORD }}
 
     - name: Build and push Docker image with tag master # only on pushes to keikoproj/upgrade-manager
       if: github.event_name == 'push' && github.repository == 'keikoproj/upgrade-manager'