Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IgnisComic #6999

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Add IgnisComic #6999

merged 2 commits into from
Jan 6, 2025

Conversation

choppeh
Copy link
Contributor

@choppeh choppeh commented Jan 5, 2025

Closes #6891

About the comments in the issue: Drake Scans still works, so I'm adding IgnisComic as a new source

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@choppeh choppeh closed this Jan 5, 2025
@choppeh choppeh reopened this Jan 5, 2025
vetleledaal
vetleledaal previously approved these changes Jan 5, 2025
@AwkwardPeak7 AwkwardPeak7 merged commit 205c7be into keiyoushi:main Jan 6, 2025
23 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
@choppeh choppeh deleted the sr/en/igniscomic branch January 22, 2025 04:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Source Requests “Ignis Comic”
3 participants