Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mangadex markdown cleanup removes --- only with newline #7282

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

spicemace
Copy link
Contributor

@spicemace spicemace commented Jan 21, 2025

Tables are affected if any --- is removed.
Tables need other handling too in another change.
Fixes #872

Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@AwkwardPeak7
Copy link
Contributor

please test your changes

@vetleledaal vetleledaal marked this pull request as draft January 25, 2025 21:56
@spicemace spicemace marked this pull request as ready for review January 30, 2025 03:22
@spicemace
Copy link
Contributor Author

spicemace commented Jan 30, 2025

Tested with entry that has both :--- and \n--- in description, removes everything after latter, no longer removes everything after former. Table contents display in full, but following section is correctly removed.

@AwkwardPeak7
Copy link
Contributor

please give example manga where this behavior can be seen

@spicemace
Copy link
Contributor Author

please give example manga where this behavior can be seen

NSFW/R18 https://mangadex.org/title/c18875a8-859d-44e5-ac64-aad167862363

Before change, table cuts off after Namespace Tags row. After change, table is displayed fully, and description ends at line before Additional Links.

@AwkwardPeak7
Copy link
Contributor

please bump version again

@AwkwardPeak7 AwkwardPeak7 merged commit e552ecc into keiyoushi:main Feb 4, 2025
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MangaDex description lost
2 participants