Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domains with no A record #7481

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vetleledaal
Copy link
Contributor

@vetleledaal vetleledaal commented Feb 2, 2025

Note: some sites might have migrated elsewhere and not left a redirect. That has not been accounted for. All removals are under the assumption that no A record = dead site.

Removes:
Eromanhwa
Frelein Books
Comic Arab
Manga.ae
Kuma Scans (Kuma Translation)
LuxManga
Manga1k
Manga Fun --- Closes #6488
Manga Tx.gg (unoriginal)
Meow Meow Comics
Night Comic
Rmanga.app
Silent Manga Audition
Silent Sky
Solo Leveling
Zinmanga.ms
Ragnarok No Chikara
Alceascan
Comic Fx
Komikid
MangaID
Siimanga
Argos Comics.com.br
Hikari Ga Nai
Imagine Scan
Link Start Scan
MoonLovers Scan
Epikman
HentaiZM
İmparator Manga
Mangacim
Prunus Scans
HentaiVN
TruyenGiHot


Found domains without A records with:

rg -I -o "\bhttps://[^'/\"\` \]\),]+" ~/dev/keiyoushi-extensions | grep -v '\$' | sort | uniq | cut -d/ -f3 > tmp_all.txt
parallel 'dig +short A {} | grep -q . || echo {}' :::: tmp_all.txt > tmp_no_a.log

+ some manual checks


Checklist:

  • Updated extVersionCode value in build.gradle for individual extensions
  • Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
  • Referenced all related issues in the PR body (e.g. "Closes #xyz")
  • Added the isNsfw = true flag in build.gradle when appropriate
  • Have not changed source names
  • Have explicitly kept the id if a source's name or language were changed
  • Have tested the modifications by compiling and running the extension through Android Studio
  • Have removed web_hi_res_512.png when adding a new extension

@AwkwardPeak7
Copy link
Contributor

hentaidexy domain changed: #7467

@vetleledaal
Copy link
Contributor Author

Not sure how that one slipped through. I somehow managed to exclude build.gradle for it, but not the src folder. I'll remove it completely from this PR.

@vetleledaal vetleledaal marked this pull request as draft February 3, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manga Fun extension isn't working
2 participants