feat: Add support for nested types Cecil and Sre #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can anyone review? Please |
kekekeks
reviewed
Aug 1, 2024
src/XamlX.IL.Cecil/CecilAssembly.cs
Outdated
| } | ||
|
|
||
| var resolved = tref?.Resolve(); | ||
| if (resolved?.IsNestedPrivate == false) |
There was a problem hiding this comment.
We probably need to examine the entire chain, e. g.
class Foo
{
class NestedPrivate
{
public class NestedPublic {}
}
}would pass the current check.
maxkatz6
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuous of #54
Adds support for nested types specified with a + to the Cecil and Sre backend.
Closes #54
Fixes AvaloniaUI/Avalonia#2725