Add GitHub Actions for tests #31

rstm-sf · 2020-10-12T13:40:01Z

Hello!

Add GitHub Actions for tests

Upgrade tfm for core
Add actions script
Fix tests (in fact they are solved, but they are not solved and these are separate problems XamlParserTests crashes with dotnet test exception for net47 #34 )
Fix runners tests for net47 on VS

Can also close_ #33

tests/XamlParserTests/ServiceProviderTests.cs

rstm-sf · 2020-10-14T19:50:09Z

* Fix runners tests for `net47` on VS (or separate PR)

This was partially solved.

It turned out that when running the test from studio BaseDirectory from AppDomain.CurrentDomain is equal to this path C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\Common7\IDE\Extensions\TestPlatform\

For CecilNetstandardTests and CecilTests this can be solved with something like

AppDomain.CurrentDomain.AssemblyResolve += (s, e) =>
{
    var name = e.Name.Split(',').First() + ".dll";
    return Assembly.LoadFile(Path.Combine(selfDir, name));
};

But XamlParserTests depend on this

XamlX/tests/XamlParserTests/CompilerTestBase.cs

Line 77 in 697a419

public CompilerTestBase() : this(new SreTypeSystem())

or this

XamlX/src/XamlX/IL/SreTypeSystem.cs

Line 27 in 697a419

foreach (var asm in AppDomain.CurrentDomain.GetAssemblies())

which ultimately raises an exception like this

XamlX/src/XamlX/TypeSystem/TypeSystem.cs

Line 303 in 697a419

throw new XamlTypeSystemException("Unable to resolve type " + type);

rstm-sf · 2020-10-16T17:02:42Z

* Fix tests

This actually works too, but dotnet test doesn't like it https://github.com/rstm-sf/XamlX/pull/3/checks#step:9:22

But it doesn't really work anywhere. I think need to think about it

or this

XamlX/src/XamlX/IL/SreTypeSystem.cs

Line 27 in 697a419

foreach (var asm in AppDomain.CurrentDomain.GetAssemblies())

rstm-sf · 2020-10-17T14:56:19Z

This actually works too, but dotnet test doesn't like it https://github.com/rstm-sf/XamlX/pull/3/checks#step:9:22

#34

I believe adding the github actions is done. It looks like they are disabled here

kekekeks · 2020-10-17T16:02:38Z

tests/XamlParserTests/ServiceProviderTests.cs

@@ -135,11 +142,6 @@ public void TypeDescriptor_Stubs_Are_Somewhat_Usable()
                return "Value";
            }, null);
        }
-
-        public static void SetAttachedProperty(ServiceProviderTestsClass target, string value)


Why do we need this change?

This is necessary so that there are no unnecessary messages during build. Since xunit thinks this is a test. If you mark this as private, the tests will stop passing. Therefore, I separated it to another class. It looks better to me -- less dependencies

Warning xUnit1013 Public method 'SetAttachedProperty' on test class 'ServiceProviderTests' should be marked as a Theory.

kekekeks · 2020-10-17T16:09:54Z

tests/CecilTests/CompilerTestBase.cs

-
+#if NETFRAMEWORK
+            // TODO: It's the hack for VS tests
+            var selfDirectory = Path.GetDirectoryName(typeof(CompilerTestBase).Assembly.Location);


Can we check that we are running for Windows and using VS test platform? Or is it OK to do with dotnet test + Mono on Linux too?

Can we check that we are running for Windows and using VS test platform?

I did not consider this, as it seemed that it would be easier to limit the .NET Framework. In addition, in my opinion, this does not really affect, except that VS for some reason changes AppDomain.CurrentDomain.BaseDirectory

Or is it OK to do with dotnet test + Mono on Linux too?

I think not, besides mono/mono#6984

But I am far from using mono

Now I have done for everyone, but with verification AppDomain.CurrentDomain.BaseDirectory

kekekeks · 2020-10-17T16:11:03Z

tests/CecilTests/CompilerTestBase.cs

+            var selfDirectory = Path.GetDirectoryName(typeof(CompilerTestBase).Assembly.Location);
+            AppDomain.CurrentDomain.AssemblyResolve += (sender, args) =>
+            {
+                var name = args.Name.Split(',').First() + ".dll";


You do realize that .First() can be replaced with indexer access, right?

Yes, but it seems to me that it will be more readable, and besides, it will still happen

Fix to indexer access

worldbeater · 2020-10-19T21:37:06Z

.github/workflows/dotnetcore.yml

+    - name: Build CecilNetstandardTests
+      run: dotnet build tests/CecilNetstandardTests/CecilNetstandardTests.csproj
+    - name: Build CecilTests
+      run: dotnet build tests/CecilTests/CecilTests.csproj
+
+    - name: Test for netcoreapp3.1
+      run: dotnet test --framework netcoreapp3.1
+
+    - name: Test for net47 CecilNetstandardTests
+      if: matrix.os == 'windows-latest'
+      run: dotnet test --framework net47 tests/CecilNetstandardTests/CecilNetstandardTests.csproj
+    - name: Test for net47 CecilTests
+      if: matrix.os == 'windows-latest'
+      run: dotnet test --framework net47 tests/CecilTests/CecilTests.csproj
+    - name: Test for net47 XamlParserTests
+      if: matrix.os == 'windows-latest'
+      run: dotnet test --framework net47 tests/XamlParserTests/XamlParserTests.csproj


See also #35 (comment)

Probably the following setup might just work, however needs testing:

- name: Build Unit Test Projects run: dotnet build tests/**/*Tests.csproj - name: Run Unit Tests run: dotnet test --no-build working-directory: src

Copy-pasteing stuff usually isn't the best way to go.

rstm-sf · 2023-07-13T17:39:30Z

@kekekeks hello, does it make sense to update it?

rstm-sf added 2 commits October 12, 2020 16:35

Upgrade tests to netcoreapp 3.1

59c5071

Add CHECK_MSIL for write to file assembly

c0be60d

rstm-sf mentioned this pull request Oct 12, 2020

What the check File.WriteAllBytes("testasm.dll", data) in tests? #30

Closed

kekekeks approved these changes Oct 12, 2020

View reviewed changes

rstm-sf added 2 commits October 12, 2020 18:20

Add script for actions

a7418b1

Fix build

af8c5d0

rstm-sf commented Oct 13, 2020

View reviewed changes

tests/XamlParserTests/ServiceProviderTests.cs Outdated Show resolved Hide resolved

rstm-sf added 2 commits October 13, 2020 16:30

Fix test for AttachedProperty

1c34385

Fix build scripts

7fa4620

rstm-sf mentioned this pull request Oct 17, 2020

Tests/benchmarks failing #33

Open

rstm-sf added 3 commits October 17, 2020 17:03

Replace !NETCOREAPP && !NETSTANDARD to NETFRAMEWORK

26dc6bc

Add hacks for tests

f541887

Separate tests for net47

5fe0c4d

rstm-sf marked this pull request as ready for review October 17, 2020 14:47

kekekeks reviewed Oct 17, 2020

View reviewed changes

rstm-sf added 3 commits October 17, 2020 22:37

Optimize resolving assembly

3e2325e

Show explicitly why we need to resolve assembly

f6130bf

Clarify why assembly resolution depends

2193c2e

rstm-sf mentioned this pull request Oct 18, 2020

Refactor the test code #35

Closed

worldbeater reviewed Oct 19, 2020

View reviewed changes

rstm-sf added 4 commits October 22, 2020 23:01

Fix exception in VS

ac24ab0

Fix build Benchmarks

33d5ab5

Fix build linux

52b4c14

Merge branch 'master' into infra/add_github_actions

b5bd02e

rstm-sf closed this Sep 1, 2023

rstm-sf deleted the infra/add_github_actions branch September 1, 2023 10:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GitHub Actions for tests #31

Add GitHub Actions for tests #31

rstm-sf commented Oct 12, 2020 •

edited

Loading

rstm-sf commented Oct 14, 2020

rstm-sf commented Oct 16, 2020

rstm-sf commented Oct 17, 2020 •

edited

Loading

kekekeks Oct 17, 2020

rstm-sf Oct 17, 2020

kekekeks Oct 17, 2020

rstm-sf Oct 17, 2020

rstm-sf Oct 17, 2020

kekekeks Oct 17, 2020

rstm-sf Oct 17, 2020

rstm-sf Oct 17, 2020

worldbeater Oct 19, 2020 •

edited

Loading

rstm-sf commented Jul 13, 2023

Add GitHub Actions for tests #31

Add GitHub Actions for tests #31

Conversation

rstm-sf commented Oct 12, 2020 • edited Loading

rstm-sf commented Oct 14, 2020

rstm-sf commented Oct 16, 2020

rstm-sf commented Oct 17, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

worldbeater Oct 19, 2020 • edited Loading

Choose a reason for hiding this comment

rstm-sf commented Jul 13, 2023

rstm-sf commented Oct 12, 2020 •

edited

Loading

rstm-sf commented Oct 17, 2020 •

edited

Loading

worldbeater Oct 19, 2020 •

edited

Loading