fix: fix infinite loop on expressions resolving only inside a DST forward jump #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheerlox
changed the title
intcreator
force-pushed
the
fix/919/portugal-daylight-savings
branch
from
8401517 to
54f94d9
Compare
intcreator
approved these changes
Dec 30, 2024
|
🎉 This PR is included in version 3.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
intcreator
pushed a commit
to sheerlox/node-cron
that referenced
this pull request
Dec 30, 2024
## [3.3.2](kelektiv/node-cron@v3.3.1...v3.3.2) (2024-12-30) ### 🐛 Bug Fixes * fix infinite loop on expressions resolving only inside a DST forward jump ([kelektiv#938](kelektiv#938)) ([efb8df5](kelektiv@efb8df5)), closes [/github.com/kelektiv/pull/667/files#diff-c14c2dca8456f15417b39cfbd9758009f8eb4f3a190a415768d6e4ae6ae9dceeL473-L477](https://github.com/kelektiv//github.com/kelektiv/node-cron/pull/667/files/issues/diff-c14c2dca8456f15417b39cfbd9758009f8eb4f3a190a415768d6e4ae6ae9dceeL473-L477) [kelektiv#919](kelektiv#919) [kelektiv#919](kelektiv#919) ### ⚙️ Continuous Integrations * **action:** update marocchino/sticky-pull-request-comment action to v2.9.0 ([kelektiv#930](kelektiv#930)) ([1e7bce9](kelektiv@1e7bce9)) * **renovate:** pin GitHub action digests to semver ([kelektiv#926](kelektiv#926)) ([6541167](kelektiv@6541167)) ### ♻️ Chores * **deps:** lock file maintenance ([70c3339](kelektiv@70c3339)) * **deps:** lock file maintenance ([afad454](kelektiv@afad454)) * **deps:** lock file maintenance ([b1dbf69](kelektiv@b1dbf69)) * **deps:** pin dependencies ([kelektiv#915](kelektiv#915)) ([dfcbd3c](kelektiv@dfcbd3c)) * **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v19.6.1 ([7999427](kelektiv@7999427)) * **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/release-notes-generator to v14.0.2 ([93c9373](kelektiv@93c9373)) * **deps:** update dependency [@types](https://github.com/types)/node to v20.17.10 ([9313ffd](kelektiv@9313ffd)) * **deps:** update dependency lint-staged to v15.2.11 ([100c9ff](kelektiv@100c9ff))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes a superfluous
+ 1modifying the behavior unexpectedly. Using the debugger I've located the bug to this instruction, and it can easily be confirmed that this+ 1is the issue, sincedate.month&this.monthare both indexed starting from1(and not0).Not sure how long this bug has been around, but it was already present when we aligned with the UNIX standard.
Related Issue
Fixes #919.
Motivation and Context
Fixes an infinite loop when a cron expression only resolves to inside a DST jump. See #919 for more.
How Has This Been Tested?
Added two new test cases, and made sure they triggered the infinite loop before writing the fix.
Screenshots (if appropriate):
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).