Add an as_uri method #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. What happens on Windows if you don't set |
|
@kenahoo I'm not sure. I think it should get the OS from the object (if it can) and pass that the URI::file. I also realise that I forgot to add POD for the method. |
- Added items for as_uri method to the POD. - Whitespace cleanup.
|
@kenahoo I've added some tests for Win32 as well as POD. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds an
as_urimethod that returns aURI::fileobject, along with some rudimentary tests.It does not support file URIs for other operating systems (such as Windows).