Ensures MatFormField label is always present

kendraio · Nov 26, 2024 · 0b90eaf · 0b90eaf
1 parent b429dc2
commit 0b90eaf
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/cypress/e2e/spec.ts b/cypress/e2e/spec.ts
@@ -72,7 +72,7 @@ describe('workspace-project App', () => {
     cy.get('[data-cy="toolbar-setting-button"]').click();
     cy.get('app-workflow-sidenav').contains('testingComment').should('exist');
     cy.get('app-workflow-sidenav').contains('testingComment').click();  
-    // cy.get('app-workflow-sidenav').contains('Block Comment'); // FIXME: regression - MatFormField placeholder text is not visible
+    cy.get('app-workflow-sidenav').contains('Block Comment');
   });
 
 

diff --git a/src/app/components/block-builder-box/block-builder-box.component.html b/src/app/components/block-builder-box/block-builder-box.component.html
@@ -6,6 +6,7 @@
 </ng-container>
 
 <mat-form-field class="block-comment-container">
-  <textarea type="textarea" rows="2" placeholder="Block Comment" aria-label="Block Comment" matInput
+  <mat-label>Block Comment</mat-label>
+  <textarea type="textarea" rows="2" aria-label="Block Comment" matInput
     [formControl]="blockCommentFormControl" ></textarea>
 </mat-form-field>
diff --git a/src/app/components/block-mapping-builder-box/block-mapping-builder-box.component.html b/src/app/components/block-mapping-builder-box/block-mapping-builder-box.component.html
@@ -1,5 +1,6 @@
 <ngx-monaco-editor [options]="editorOptions" style="height: 240px;" [(ngModel)]="mappingModel"></ngx-monaco-editor>
 <mat-form-field class="block-comment-container">
-  <textarea type="textarea" rows="3" placeholder="Block Comment" aria-label="Block Comment" matInput
+  <mat-label>Block Comment</mat-label>
+  <textarea type="textarea" rows="3" aria-label="Block Comment" matInput
     [formControl]="blockCommentFormControl" ></textarea>
 </mat-form-field>