Skip to content

Commit

Permalink
Adds flow-analysis folder to save flows & analysis
Browse files Browse the repository at this point in the history
  • Loading branch information
@lukestanley
lukestanley committed Oct 24, 2023
1 parent 264bdd6 commit f4635d5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/extract-example-block-usage-from-flows.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
*/


let inputFilePath = 'flows.json';
let outputFilePath = 'flow-block-config-analysis.json';
let inputFilePath = 'flow-analysis/flows.json';
let outputFilePath = 'flow-analysis/flow-block-config-analysis.json';
let blockType = 'form'; // Replace with the block type you're interested in
let propertyOfInterest = null; // E.g: 'uiSchema' - replace with the property you're interested in or leave as null

Expand Down
1 change: 1 addition & 0 deletions docs/flow-analysis/README.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Analysed flows will be saved here using the extraction script in the parent directory.

3 comments on commit f4635d5

@dahacouk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukestanley please don't use & in titles when you mean and. Please use and. Thanks.

@lukestanley
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a space constraint when saving commit messages. Only part gets shown. I had "and" originally but needed to fit it in. I already had done a few iterations at making it shorter so it would fit in and the ampersand was the only way I could think to squeeze it in. It didn't occur to me to put: "Adds flow-analysis folder to save flow analysis" (it saves the flows too but that would have been acceptable enough too).

@dahacouk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukestanley I feel your pain. Seriously. And thanks for trying. Yes, I reckon it is best not to use ampersand at all because if one of us does then it will be seen as a green light to others. We need to be rigorous. Thanks.

Please sign in to comment.