Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't track docker-compose.yml, and update dependencies that are easily updated #266

Merged

Conversation

za419
Copy link
Contributor

@za419 za419 commented Jul 31, 2024

Those dependencies being "Not Liquidsoap" - Even though our liquidsoap is absurdly far out of date, I really don't feel like bumping the major version, especially not when I'm not knowledgeable in that domain.

Therefore, see #265.

za419 added 3 commits July 30, 2024 19:17
Tracking this feels like a mistake - The example file exists, and
overwrites the .yml when install gets run. That shouldn't make the repo
have uncommitted changes, nor should checking out a new branch break
your install, nor should what goes in compose upon install get put in
PRs and such.
@kenellorando
Copy link
Owner

Thanks for these PRs @za419. I'll get started processing.

@kenellorando kenellorando merged commit a287dcf into kenellorando:master Aug 1, 2024
1 check passed
kenellorando added a commit that referenced this pull request Aug 6, 2024
I noticed we never allow overriding of the log level from Info, even
though we do log at lower levels. This provides a mechanism to fix this
- I thought it might be potentially helpful in debugging population
errors (as #264 might be).

This partially depends on, and therefore has some similar diffs to,
#266.

Default output:

![image](https://github.com/user-attachments/assets/289cbb49-fe0d-42aa-badf-534f4f0f50f4)

With level=Debug (and the ideal Cadence dev music folder):

![image](https://github.com/user-attachments/assets/04e7d23f-6960-4efc-afef-94e4edf29bfe)

Commandline that sets Debug:

![image](https://github.com/user-attachments/assets/1961cb28-d4a1-4cca-8b53-498e8aba6955)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants