fix: reset $this->group_by

kenjis · Aug 9, 2023 · 4e6486b · 4e6486b
1 parent 509266b
commit 4e6486b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/CI3Compatible/Database/CI_DB_query_builder.php b/src/CI3Compatible/Database/CI_DB_query_builder.php
@@ -694,6 +694,7 @@ private function _reset_select()
         $this->from = [];
         $this->join = [];
         $this->where = [];
+        $this->group_by = [];
         $this->like = [];
         $this->order_by = [];
     }

diff --git a/tests/CI3Compatible/Database/CI_DB_query_builderTest.php b/tests/CI3Compatible/Database/CI_DB_query_builderTest.php
@@ -147,6 +147,20 @@ public function test_group_by_multiple_calls(): void
         $this->assertSame($expected, $sql);
     }
 
+    public function test_group_by_multiple_queries(): void
+    {
+        $this->queryBuilder->group_by('title');
+        $this->queryBuilder->get('news');
+
+        $this->queryBuilder->get('news');
+
+        $db = $this->queryBuilder->getBaseConnection();
+        $sql = (string) $db->getLastQuery();
+        $expected = 'SELECT *
+FROM `db_news`';
+        $this->assertSame($expected, $sql);
+    }
+
     public function test_count_all(): void
     {
         $count = $this->queryBuilder->count_all('news');