Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Github teams as reviewers #120

Merged
merged 4 commits into from
Mar 3, 2020
Merged

Add support for Github teams as reviewers #120

merged 4 commits into from
Mar 3, 2020

Conversation

mrlubos
Copy link
Contributor

@mrlubos mrlubos commented Feb 27, 2020

What has been done

  • add support for Github teams in the reviewers list

How to test

  • add a Github team into your reviewers list in auto_assign.yml as /{team_slug}

Todo

  • add support for Github teams elsewhere?

@mrlubos
Copy link
Contributor Author

mrlubos commented Feb 27, 2020

Hey @kentaro-m, I added support for Github teams in the reviewers list as discussed in #102. Please let me know your feedback on this functionality and coding style and hopefully we can push this into master! 🚢

Copy link
Owner

@kentaro-m kentaro-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @mrlubos! Thank you for adding new features. I like this feature. I added some feedback comments.

Could you add a simple description of supporting Github teams as reviewers to README.md?

Also, I think it would be easy for users to understand if you add special notes: If you use to adding reviewers as the GitHub team, Not support adding randomly.

Please check my comment and let me know if you have any questions.

src/util.ts Outdated Show resolved Hide resolved
@mrlubos
Copy link
Contributor Author

mrlubos commented Mar 2, 2020

Thank you for the review @kentaro-m. Yes, I will make all of those changes. Just wanted to get the ball rolling with the code first, I will document it in the next commits.

@mrlubos mrlubos requested a review from kentaro-m March 2, 2020 20:23
@mrlubos
Copy link
Contributor Author

mrlubos commented Mar 2, 2020

I made the requested changes @kentaro-m. Please let me know if you're happy with this!

Copy link
Owner

@kentaro-m kentaro-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrlubos
I checked your changes. Good work!

@kentaro-m kentaro-m merged commit 41d2eee into kentaro-m:master Mar 3, 2020
@mrlubos mrlubos deleted the feature/team-reviewers branch March 3, 2020 22:21
@mrlubos
Copy link
Contributor Author

mrlubos commented Mar 3, 2020

Thank you @kentaro-m! When do you think will this be ready for use in my Github organisation?

@kentaro-m
Copy link
Owner

@mrlubos
I have already deployed the app for the new version. Now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants