-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Github teams as reviewers #120
Conversation
Hey @kentaro-m, I added support for Github teams in the reviewers list as discussed in #102. Please let me know your feedback on this functionality and coding style and hopefully we can push this into master! 🚢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @mrlubos! Thank you for adding new features. I like this feature. I added some feedback comments.
Could you add a simple description of supporting Github teams as reviewers to README.md?
Also, I think it would be easy for users to understand if you add special notes: If you use to adding reviewers as the GitHub team, Not support adding randomly.
Please check my comment and let me know if you have any questions.
Thank you for the review @kentaro-m. Yes, I will make all of those changes. Just wanted to get the ball rolling with the code first, I will document it in the next commits. |
I made the requested changes @kentaro-m. Please let me know if you're happy with this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrlubos
I checked your changes. Good work!
Thank you @kentaro-m! When do you think will this be ready for use in my Github organisation? |
@mrlubos |
What has been done
How to test
auto_assign.yml
as/{team_slug}
Todo