fix: humanize wasn't showing cause properly

kepler16 · Oct 27, 2022 · 63775e4 · 63775e4 · vercel · Oct 27, 2022
1 parent 5d79cb4
commit 63775e4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/k16/gx/beta/errors.cljc b/src/k16/gx/beta/errors.cljc
@@ -41,7 +41,9 @@
      :always (into (filter (fn [[_ v]] v) *err-ctx*))
      message (assoc :message message)
      internal-data (assoc :internal-data internal-data)
-     cause (update :causes conj cause))))
+     cause (update :causes conj {:title (ex-message cause)
+                                 :data (ex-data cause)
+                                 :exception cause}))))
 
 (defn throw-gx-err
   ([message]
@@ -82,6 +84,7 @@
 
 (defn humanize-error
   [{:keys [node-key signal-key message causes]} & rest-of-error]
+  (println message causes)
   (let [rest-of-error (filter seq rest-of-error)]
     (apply str (concat [(or message "Error") ": "
                         (tokenize "node = " node-key

diff --git a/test/k16/gx/beta/async_processor_test.cljc b/test/k16/gx/beta/async_processor_test.cljc
@@ -34,11 +34,13 @@
                      :my-component
                      :causes 
                      first
+                     :exception
                      (ex-data))
             :cljs (-> (gx/failures s)
                       :my-component
                       :causes
                       first
+                      :exception
                       (ex-data))))))
 
 #_{:clj-kondo/ignore [:clojure-lsp/unused-public-var]}

diff --git a/test/k16/gx/beta/core_test.cljc b/test/k16/gx/beta/core_test.cljc
@@ -636,5 +636,5 @@
        (let [{:keys [error-type causes] :as failures} (:comp (gx/failures started))]
          (is (= :props-validation error-type))
          (is (= ":malli.core/invalid-schema {:schema :bar}"
-                (-> causes first ex-message))))))))
+                (-> causes first :title))))))))