Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make module override in subcommands a flag #8

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

nikolubbe
Copy link
Contributor

The module option was a positional argument for most commands, but that does not make sense to me because:

  • You can set a default (the common use-case)
  • If you omit the module, and do not have a default module set, you will be prompted to select a module to operate on
  • The subcommands read something like this:
    kl services set-endpoint <module-name> <service-name> <"host" | "container">
    This read easier in my opinion:
    kl services set-endpoint <service-name> <"host" | "container> with the option to specify -m or --module to override

@nikolubbe nikolubbe requested a review from julienvincent July 24, 2024 09:33
@julienvincent
Copy link
Collaborator

Makes sense to me

@nikolubbe nikolubbe merged commit fc9d1fb into master Jul 24, 2024
10 checks passed
@nikolubbe nikolubbe deleted the nl/make-module-flag branch July 24, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants