Merge pull request #35 from kepler16/fix/await-repl-shutdown

fix: await repl shutdown
kepler16 · Jul 10, 2024 · 194cfb4 · 194cfb4
2 parents 582978f + 3d40606
commit 194cfb4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/.github/workflows/release_binary.yml b/.github/workflows/release_binary.yml
@@ -115,5 +115,7 @@ jobs:
           mv checksums.txt bin/checksums.txt
 
       - name: GH Release
-        run: gh release create ${{ needs.build.outputs.release_tag }} bin/*
+        run: |
+          gh release create ${{ needs.build.outputs.release_tag }} bin/* \
+            --title "Release ${{ needs.build.outputs.release_tag }}"
 
diff --git a/src/k16/kmono/repl/deps.clj b/src/k16/kmono/repl/deps.clj
@@ -266,8 +266,12 @@
       (ansi/print-info "Running clojure...")
       (when verbose?
         (print-clojure-cmd sdeps-overrides main-opts))
-      (let [proc (bp/shell {:continue true} clojure-cmd)]
+      (let [proc (bp/process {:inherit true} clojure-cmd)]
         (doto (Runtime/getRuntime)
-          (.addShutdownHook (Thread. (fn [] (bp/destroy proc)))))
+          (.addShutdownHook
+           (Thread.
+            (fn []
+              (bp/destroy proc)
+              (bp/check proc)))))
         (bp/check proc)))))