Handle mismatches between oplog + known ops #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation handles mismatches between the op-log and known set of operations quite badly. It is required that the current op-log head points to a known and explicitly provided operation. This can cause issues in the following scenarios: + Working accross two different branches and applied operations from one branch not existing in the second. + Deleting applied operations because it is no longer desireable to keep the code around. Another issue exists as a result of this approach; information regarding the order in which operations were actually applied is lost. This may be distinct from the order in which operations were provided. When executing in the :down direction it would be safer to execute in the reverse order to which operations were applied. This commit resolves this issue by: + No longer requiring operations that have been applied to be provided at all. + Re-ordering operations based on the order they appear in the op-log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation handles mismatches between the op-log and known set of operations quite badly.
It is required that the current op-log head points to a known and explicitly provided operation.
This can cause issues in the following scenarios:
Another issue exists as a result of this approach; information regarding the order in which operations were actually applied is lost. This may be distinct from the order in which operations were provided.
When executing in the :down direction it would be safer to execute in the reverse order to which operations were applied.
This commit resolves this issue by: