Merge pull request #121 from rishavmehra/rishavmehra/improvement #100
Annotations
8 errors and 11 warnings
http-pokeapi/internal/pokeapi/poke_req.go#L42
Error return value of `res.Body.Close` is not checked (errcheck)
|
http-pokeapi/internal/pokeapi/poke_req.go#L78
Error return value of `res.Body.Close` is not checked (errcheck)
|
http-pokeapi/internal/pokeapi/poke_req.go#L114
Error return value of `res.Body.Close` is not checked (errcheck)
|
http-pokeapi/response.go#L31
Error return value of `w.Write` is not checked (errcheck)
|
http-pokeapi/internal/models/location_models.go#L1
File is not `gofmt`-ed with `-s` (gofmt)
|
http-pokeapi/internal/models/pokemon_models.go#L1
File is not `gofmt`-ed with `-s` (gofmt)
|
http-pokeapi/internal/pokeapi/poke_req.go#L1
File is not `gofmt`-ed with `-s` (gofmt)
|
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
http-pokeapi/internal/pokeapi/poke_req.go#L89
receiver-naming: receiver name c should be consistent with previous receiver name client for Client (revive)
|
http-pokeapi/internal/pokeapi/poke_req.go#L11
var-naming: don't use underscores in Go names; const base_url should be baseURL (revive)
|
http-pokeapi/internal/pokeapi/poke_req.go#L18
var-naming: don't use underscores in Go names; var end_url should be endURL (revive)
|
http-pokeapi/internal/pokeapi/poke_req.go#L19
var-naming: don't use underscores in Go names; var full_url should be fullURL (revive)
|
http-pokeapi/internal/pokeapi/poke_req.go#L54
var-naming: don't use underscores in Go names; var end_url should be endURL (revive)
|
http-pokeapi/internal/pokeapi/poke_req.go#L55
var-naming: don't use underscores in Go names; var full_url should be fullURL (revive)
|
http-pokeapi/internal/pokeapi/poke_req.go#L90
var-naming: don't use underscores in Go names; var end_url should be endURL (revive)
|
http-pokeapi/internal/pokeapi/poke_req.go#L91
var-naming: don't use underscores in Go names; var full_url should be fullURL (revive)
|
http-pokeapi/response.go#L21
var-naming: func respondWithJson should be respondWithJSON (revive)
|
http-pokeapi/location.go#L9
unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
|
This job failed
Loading