Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced classes to stateless components and used hooks to replace li… #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daruj
Copy link

@daruj daruj commented Oct 18, 2019

Why: To avoid warnings an conflicts with future versions.

- componentWillReceiveProps has been renamed, and is not recommended for use.
- Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work

What have I done:

  • Replaced classes to stateless components and used hooks to replace lifecycles.
  • Upgraded react & react-dom versions
  • Updated example (removed react-router that was not really needed)

…fecycles. Also upgraded react & react-dom version and updated the example
@sangdth
Copy link

sangdth commented Nov 6, 2019

The fail actually just eslint check. I'm really looking forward this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants