Skip to content
This repository has been archived by the owner on Nov 3, 2022. It is now read-only.

Adding other codeowners. #447

Merged

Conversation

gabrieldemarmiesse
Copy link
Contributor

- What I did
I added other codeowners.

- How I did it
I got them from itssue #415

- How you can verify it

The tests are passing.

@gabrieldemarmiesse gabrieldemarmiesse merged commit 8adf083 into keras-team:master Feb 10, 2019
@titu1994
Copy link
Contributor

Could you add me to the list as discussed in PR #415 as well ?

@gabrieldemarmiesse
Copy link
Contributor Author

Could you give the list of features? We discussed quite some things and I don't want to make a mistake.

@titu1994
Copy link
Contributor

Sure. They are:

  • all applications other than ResNet
  • callbacks/snapshot: entire module
  • layers/convolution: SubPixelUpscaling
  • layers/normalization: GroupNormalization

@gabrieldemarmiesse
Copy link
Contributor Author

Thanks! I'll split the convolution and normalization modules and then add you as the codeowner.

@titu1994
Copy link
Contributor

Thanks !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants