This repository has been archived by the owner on Nov 3, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 3 issues in initializers/convaware.py:
rank == 4
to correctly returncolumn
androw
in the correct order (re: Issue ConvolutionAware error #479)dtype
to__call__
(as per it's parent class) rather than relying onK.floatx()
K.variable()
of the correctdtype
rather than a numpy array ofdtype
K.floatx()
Verification
ICNR
initializer) with a differentdtype
to that stored inK.floatx()
, this PR will succeed where the original code will fail.ICNR
) using Tensorflow backend as the returned numpy array forces a tensorflow Channel Order error. By returning aK.variable()
from this initializer, that error is avoided.This pull request fixes #479