Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Image classification with ConvMixer to keras-core #941

Closed

Conversation

divyashreepathihalli
Copy link
Collaborator

@divyashreepathihalli divyashreepathihalli commented Sep 22, 2023

  • fixed imports
  • removed tfa dependency

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9bf92c8) 83.83% compared to head (d528e22) 83.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     keras-team/keras-core#941   +/-   ##
=======================================
  Coverage   83.83%   83.83%           
=======================================
  Files         319      319           
  Lines       28879    28879           
  Branches     5529     5529           
=======================================
  Hits        24211    24211           
  Misses       3148     3148           
  Partials     1520     1520           
Flag Coverage Δ
keras_core 83.72% <ø> (ø)
keras_core-jax 67.11% <ø> (ø)
keras_core-numpy 60.56% <ø> (ø)
keras_core-tensorflow 67.08% <ø> (ø)
keras_core-torch 69.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Does the example work with all backends? If so we should move it out of the tensorflow directory.

examples/keras_io/tensorflow/vision/convmixer.py Outdated Show resolved Hide resolved
@divyashreepathihalli
Copy link
Collaborator Author

divyashreepathihalli commented Sep 22, 2023

Thanks for the PR! Does the example work with all backends? If so we should move it out of the tensorflow directory.

I had to change data augmentation from a sequential model to a function for it to work with all the backends. I have filed an issue with a repro here - keras-team/keras#18396

@fchollet
Copy link
Contributor

Keras Core is becoming Keras 3, and we're switching development to the main repository! Please reopen this PR in the keras-team/keras repository. Unfortunately we aren't able to automatically transfer PRs (but we have transferred all issues).

@fchollet fchollet closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants