-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTC API for JAX #18952
Merged
Merged
CTC API for JAX #18952
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
8ca8bf8
Implement CTC loss in tensorflow backend
MaanasArora 3b2d7ca
Implement CTC api in torch backend
MaanasArora ecbb28e
Add CTC loss to keras losses
MaanasArora e7584f7
Remove CTC from losses
MaanasArora f7554b4
Perform log softmax in torch CTC loss
MaanasArora cbbd628
Refactor reviewed code in CTC API
MaanasArora cb97574
Fix formatting issue in docstring
MaanasArora bedad98
Removed trailing space
MaanasArora ab2efc9
Naming changes in nn.ctc_loss backend functions
MaanasArora 0741531
Add ctc_loss keras op
MaanasArora 1ffa35d
Add correctness unit test for CTC loss
MaanasArora 4edf18d
Skip test for CTC loss in JAX backend
MaanasArora 85865ba
Update ctc_loss function to also export to ops.nn
MaanasArora ab8a81b
Add static type testing for CTC loss
MaanasArora 92e6654
Fix enabled backends for CTC loss test
MaanasArora 97873a0
Linting keras ops
MaanasArora cfd949e
Fix line overflow in CtcLoss class
MaanasArora 58caf83
CTC loss implementation for JAX
MaanasArora 56d84dd
Merge branch 'master' of github.com:keras-team/keras into ctc-jax
MaanasArora 90801dc
Fix shape order in ctc loss documentation
MaanasArora 28032cd
Transpose output in CTC loss
MaanasArora 9f266e3
Use logits_time_major instead of transpose in TF CTC
MaanasArora 5e98c5c
Fix linting issue
MaanasArora File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary for the scan op on the first dimension?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes AFAIK, since we're scanning along the time dimension and scan runs along the leading axis.