Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default value for input_shape when include_top is provided has False. #18954

Merged
merged 1 commit into from
Dec 17, 2023
Merged

default value for input_shape when include_top is provided has False. #18954

merged 1 commit into from
Dec 17, 2023

Conversation

yashsinghcodes
Copy link
Contributor

This was the issue raised at the time of Keras 3 code base migration from keras-team/keras-core to keras-team/keras. I was told to recreate the pull request if the issue is not fixed after the migration.

issue was: keras-team/tf-keras#142

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d550552) 79.55% compared to head (32da2a9) 53.99%.

Files Patch % Lines
keras/applications/nasnet.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #18954       +/-   ##
===========================================
- Coverage   79.55%   53.99%   -25.57%     
===========================================
  Files         337      353       +16     
  Lines       35056    37288     +2232     
  Branches     6872     7242      +370     
===========================================
- Hits        27890    20133     -7757     
- Misses       5587    15680    +10093     
+ Partials     1579     1475      -104     
Flag Coverage Δ
keras 55.97% <ø> (-23.45%) ⬇️
keras-jax ?
keras-numpy 55.97% <ø> (ø)
keras-tensorflow ?
keras-torch ?
keras.applications 22.93% <0.00%> (?)
keras.applications-numpy 22.93% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fchollet fchollet merged commit 565953a into keras-team:master Dec 17, 2023
5 of 6 checks passed
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants