Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for https://github.com/keras-team/keras/issues/18941 #18968

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

hertschuh
Copy link
Collaborator

@hertschuh hertschuh commented Dec 19, 2023

This allows the static shape to propagate in RNNs in the case when the number of time steps is fixed and known at build time.

Fixes #18941.

This allows the static shape to propagate in RNNs in the case when the number of time steps is fixed and known at build time.
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7972fca) 79.63% compared to head (7a2a1bc) 79.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18968      +/-   ##
==========================================
+ Coverage   79.63%   79.64%   +0.01%     
==========================================
  Files         338      338              
  Lines       35201    35201              
  Branches     6913     6913              
==========================================
+ Hits        28032    28036       +4     
+ Misses       5587     5584       -3     
+ Partials     1582     1581       -1     
Flag Coverage Δ
keras 79.50% <100.00%> (+0.01%) ⬆️
keras-jax 61.29% <0.00%> (-0.01%) ⬇️
keras-numpy 56.01% <0.00%> (+0.01%) ⬆️
keras-tensorflow 63.14% <100.00%> (ø)
keras-torch 63.81% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 19, 2023
@fchollet fchollet merged commit 4a4a139 into keras-team:master Dec 19, 2023
6 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Dec 19, 2023
@hertschuh hertschuh deleted the rnn_static_shape branch December 19, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

Issue with TimeDistributed + LSTM layer
4 participants