add numerical test to CI #19260
Merged
add numerical test to CI #19260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19260 +/- ##
===========================================
- Coverage 80.14% 54.02% -26.13%
===========================================
Files 341 363 +22
Lines 36163 39422 +3259
Branches 7116 7630 +514
===========================================
- Hits 28982 21296 -7686
- Misses 5578 16575 +10997
+ Partials 1603 1551 -52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for the PR!
We can add this step to the GitHub action (no need to add it to requirements.txt) |
fchollet
reviewed
Mar 8, 2024
| @@ -41,7 +44,8 @@ def build_keras_model(keras_module, num_classes): | |||
| keras_module.layers.Conv2D( | |||
| 64, kernel_size=(3, 3), activation="relu" | |||
| ), | |||
| keras_module.layers.BatchNormalization(scale=False, center=True), | |||
| # TODO: Renable the following line. | |||
There was a problem hiding this comment.
What is the issue? Numerical difference across backends?
There was a problem hiding this comment.
Yes, if I add this layer, TF and JAX tests would fail due to numerical differences.
fchollet
approved these changes
Mar 8, 2024
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
awaiting review
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19216.
Add numerical test to the CI to catch more bugs.