-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update output_padding argument in convolution transpose layer #20737
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20737 +/- ##
===========================================
- Coverage 81.95% 29.84% -52.12%
===========================================
Files 553 553
Lines 51446 51458 +12
Branches 7957 7961 +4
===========================================
- Hits 42164 15356 -26808
- Misses 7346 35542 +28196
+ Partials 1936 560 -1376
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Please add a unit test for this change.
@@ -116,6 +124,7 @@ def __init__( | |||
kernel_size=kernel_size, | |||
strides=strides, | |||
padding=padding, | |||
output_padding=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be propagated, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @fchollet, When i am using output_padding=0
in keras(3.8.0), I am getting ValueError: The
output_padding argument must be a tuple of 1 integers. Received output_padding=0, including values {0} that do not satisfy value > 0
but setting output_padding=None
, it works without error. So, should I modify the error message to raise AttributeError
or remove this argument ?
Update output_padding argument in convolution transpose layer. Fixes #19870 and #20408