Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JAX GPU CI and make formatter happy #20749

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

james77777778
Copy link
Contributor

@james77777778 james77777778 commented Jan 10, 2025

We need to increase the tolerance for the export test in TestJaxLayer

EDITED:
The new version of ruff introduces some changes. This PR also makes formatter happy.

@james77777778 james77777778 changed the title Fix JAX GPU CI Fix JAX GPU CI and make formatter happy Jan 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.95%. Comparing base (97c1c00) to head (ed88ff5).

Files with missing lines Patch % Lines
keras/src/backend/openvino/core.py 50.00% 1 Missing ⚠️
keras/src/backend/openvino/numpy.py 50.00% 1 Missing ⚠️
keras/src/callbacks/csv_logger.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #20749   +/-   ##
=======================================
  Coverage   81.95%   81.95%           
=======================================
  Files         553      553           
  Lines       51458    51458           
  Branches     7961     7961           
=======================================
  Hits        42174    42174           
  Misses       7346     7346           
  Partials     1938     1938           
Flag Coverage Δ
keras 81.78% <66.66%> (ø)
keras-jax 64.04% <33.33%> (ø)
keras-numpy 58.90% <33.33%> (ø)
keras-openvino 29.84% <33.33%> (ø)
keras-tensorflow 64.70% <33.33%> (ø)
keras-torch 64.08% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jan 10, 2025
@fchollet fchollet merged commit 3d20616 into keras-team:master Jan 10, 2025
7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Jan 10, 2025
@james77777778 james77777778 deleted the fix-jax-gpu branch January 11, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

4 participants