-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Imported from GitHub PR #779 As discussed in #776 I tried but actually run into the issue that layers/experimental cannot be used as a build target, as the builds _inside_ experimental _require_ layers -> circular deps. The other folders in `layers` circumvent this by specifying only the specific build targets. Instead of changing the logic (i.e. is experimental meant to be dev-built only?), I did what the error advertised and added it to the ignored builds, as it's seemingly not made to be built Copybara import of the project: -- 9d3bb64 by Jonas Eschle <[email protected]>: docs: update CONTRIBUTING.md with new name tf-keras (cherry picked from commit fb79960) -- 7bd7b3d by Jonas Eschle <[email protected]>: fix: python build ignore experimental due to circular refs (cherry picked from commit 9b349e3) Merging this change closes #779 FUTURE_COPYBARA_INTEGRATE_REVIEW=#779 from jonas-eschle:fix_pip_build 7bd7b3d PiperOrigin-RevId: 685927076
- Loading branch information
1 parent
2aa84ae
commit c188ac6
Showing
2 changed files
with
10 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters