Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC Support #83

Closed
wants to merge 84 commits into from
Closed

gRPC Support #83

wants to merge 84 commits into from

Commits on Feb 10, 2019

  1. Preliminary gRPC support; tentative proto file and stubbed server imp… 

    …lementation
    @mohammed90
    mohammed90 committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    77a6165 View commit details
    Browse the repository at this point in the history

  2. Break proto files into public and private API

    @mohammed90
    mohammed90 committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    41df94a View commit details
    Browse the repository at this point in the history

  3. Fix response message type for Login, RefreshSession, and ChangePassword

    @mohammed90
    mohammed90 committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    3231f7c View commit details
    Browse the repository at this point in the history

  4. Add passwordless API in protobuf definition

    @mohammed90
    mohammed90 committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    edadc20 View commit details
    Browse the repository at this point in the history

  5. Correct Alg parameter in proto definition

    @mohammed90
    mohammed90 committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    1bbc564 View commit details
    Browse the repository at this point in the history

  6. As of this commit, truly working package implementation of gRPC API i… 

    …n addition the already existing API. The gRPC API is not wired yet to the rest of the application.

The work still needs further improvement, e.g. securing the gPRC API, better logging, among others. Configuration knobs are also yet to be hooked.
    @mohammed90
    mohammed90 committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    b89b517 View commit details
    Browse the repository at this point in the history

  7. clean up gRPC package after rebase

    @mohammed90
    mohammed90 committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    a65f8f5 View commit details
    Browse the repository at this point in the history

  8. Fix go moduels error on Travis by updating go.sum

    @mohammed90
    mohammed90 committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    c97be29 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2019

  1. Add gRPC specific configuration parameters

    @mohammed90
    mohammed90 committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    ff81f7f View commit details
    Browse the repository at this point in the history

  2. refactor gRPC interceptors

    @mohammed90
    mohammed90 committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    41a4bc0 View commit details
    Browse the repository at this point in the history

  3. add helper function to convert gRPC BadRequest to FieldErrors

    @mohammed90
    mohammed90 committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    3d57b10 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2019

  1. grpc: add tests for gRPC services

    @mohammed90
    mohammed90 committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    6209eef View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. grpc: make it possible to have the gRPC-gateway mounted on subpath

    @mohammed90
    mohammed90 committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    fc9c889 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2019

  1. grpc: gateway: fix path trimming handler where it removes the first s… 

    …lash "/"
    @mohammed90
    mohammed90 committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    e260474 View commit details
    Browse the repository at this point in the history

  2. grpc: wire the grpc server to the main func

    @mohammed90
    mohammed90 committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    f71d462 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2019

  1. grpc: privatize the service runner funcs

    @mohammed90
    mohammed90 committed Apr 7, 2019
    Configuration menu
    Copy the full SHA
    e72f8fb View commit details
    Browse the repository at this point in the history

  2. grpc: fix the calling func to actually call the adjusted func names

    @mohammed90
    mohammed90 committed Apr 7, 2019
    Configuration menu
    Copy the full SHA
    d1da5df View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Merge branch 'master' into grpc-api

    @cainlevy
    cainlevy authored Apr 9, 2019
    Configuration menu
    Copy the full SHA
    f4ed200 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Merge branch 'master' into grpc-api

    @mohammed90
    mohammed90 authored Apr 12, 2019
    Configuration menu
    Copy the full SHA
    d32bec5 View commit details
    Browse the repository at this point in the history

  2. grpc: clean up leftover log print

    @mohammed90
    mohammed90 committed Apr 12, 2019
    Configuration menu
    Copy the full SHA
    79e863e View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2019

  1. grpc: remove TLS-related configuration and wiring

    @mohammed90
    mohammed90 committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    337fef3 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. grpc: make: remove dependency on vendor/ for gogoproto files

    @mohammed90
    mohammed90 committed May 4, 2019
    Configuration menu
    Copy the full SHA
    a68a83b View commit details
    Browse the repository at this point in the history

Commits on May 8, 2019

  1. grpc: include panic recovery interceptor and grpc-specific error repo… 

    …rter
    @mohammed90
    mohammed90 committed May 8, 2019
    Configuration menu
    Copy the full SHA
    fce9e70 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2019

  1. gracefully stop server on kill signals

    @mohammed90
    mohammed90 committed May 10, 2019
    Configuration menu
    Copy the full SHA
    dbdf512 View commit details
    Browse the repository at this point in the history

  2. grpc: remove reference of OAuth in proto file

    @mohammed90
    mohammed90 committed May 10, 2019
    Configuration menu
    Copy the full SHA
    655feb9 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2019

  1. The JSON encoder/decoder provided by gRPC-gateway runtime silently co… 

    …nverts (u)int64 to strings (see: grpc-ecosystem/grpc-gateway#920 ),

which is compliant with the Proto3 spec. However, this affects our response negatively because it breaks backwards compatibilty. Go's
JSON encoder/decoder doesn't have such surprises. This commit replaces runtime.JSONPb (from gRPC-Gateway) with a wrapper
around the stdlib JSON encoder/decoder.
    @mohammed90
    mohammed90 committed May 16, 2019
    Configuration menu
    Copy the full SHA
    21b06d9 View commit details
    Browse the repository at this point in the history

  2. grpc: ignore nil errors returned from server#Serve

    @mohammed90
    mohammed90 committed May 16, 2019
    Configuration menu
    Copy the full SHA
    9401114 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2019

  1. grpc: gateway: correctly reply with 401 to invalid refresh requests

    @mohammed90
    mohammed90 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    a270ce4 View commit details
    Browse the repository at this point in the history

  2. grpc: gateway: handle cookies and session token parsing properly

    @mohammed90
    mohammed90 committed May 24, 2019
    Configuration menu
    Copy the full SHA
    d048bd8 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2019

  1. Merge branch 'master' into grpc-api

    @mohammed90
    mohammed90 committed Jun 1, 2019
    Configuration menu
    Copy the full SHA
    c083b36 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. grpc: gateway: fix improper marshal of PUT and PATCH request

    @mohammed90
    mohammed90 committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    d3b2ee4 View commit details
    Browse the repository at this point in the history

  2. grpc: gateway: initial set of comprehensive server test suite

    @mohammed90
    mohammed90 committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    1ab03fc View commit details
    Browse the repository at this point in the history

  3. redis: the github.com/go-redis/redis already handles missing port in URL

    @mohammed90
    mohammed90 committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    9bde604 View commit details
    Browse the repository at this point in the history

  4. grpc: adapt grpc/private package to new key generation strategy

    @mohammed90
    mohammed90 committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    bfa093b View commit details
    Browse the repository at this point in the history

  5. grpc: gateway: remove debug log statement

    @mohammed90
    mohammed90 committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    720d371 View commit details
    Browse the repository at this point in the history

  6. grpc: test: allow for dynamic user ID

    @mohammed90
    mohammed90 committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    4324485 View commit details
    Browse the repository at this point in the history

  7. grpc: test: fix CI build failure

    @mohammed90
    mohammed90 committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    3fae17b View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2019

  1. grpc: gateway: log appropriate message on shutdown

    @mohammed90
    mohammed90 committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    9563ef7 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2019

  1. Switch from locally available protoc executable to Docker-contained e… 

    …xecutable in the thethingsindustries/protoc image.

This reduces the need for locally available protoc et. al., and allows for more control over the versions of protoc plugins.
    @mohammed90
    mohammed90 committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    13467e2 View commit details
    Browse the repository at this point in the history

  2. remove leftover variables in Makefile

    @mohammed90
    mohammed90 committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    28601d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2019

  1. grpc: enable Prometheus handling time histogram

    @mohammed90
    mohammed90 committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    0b75b1d View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2019

  1. grpc: gateway: add routing tests

    @mohammed90
    mohammed90 committed Jun 21, 2019
    Configuration menu
    Copy the full SHA
    95e897a View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2019

  1. grpc: gateway: gateway's /stats handler should only be registered if … 

    …/Actives is not nil
    @mohammed90
    mohammed90 committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    63c381c View commit details
    Browse the repository at this point in the history

  2. grpc: remove remnants of mTLS authnetication in tests

    @mohammed90
    mohammed90 committed Jun 22, 2019
    Configuration menu
    Copy the full SHA
    6f30a4e View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2019

  1. Merge branch 'master' into grpc-api

    @mohammed90
    mohammed90 authored Jun 28, 2019
    Configuration menu
    Copy the full SHA
    283760a View commit details
    Browse the repository at this point in the history

  2. grpc: export services.FieldError and use it instead of errors.FieldError

    @mohammed90
    mohammed90 committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    bdc4eee View commit details
    Browse the repository at this point in the history

  3. grpc: fix typos and stylistic naming choices

    @mohammed90
    mohammed90 committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    98c2237 View commit details
    Browse the repository at this point in the history

  4. grpc: gateway: return on form-to-JSON marshallig failure

    @mohammed90
    mohammed90 committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    2ec8d20 View commit details
    Browse the repository at this point in the history

  5. grpc: gateway: reuse existing CORS middleware

    @mohammed90
    mohammed90 committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    aad86e4 View commit details
    Browse the repository at this point in the history

  6. grpc: gateway: deduplicate root handler

    @mohammed90
    mohammed90 committed Jun 28, 2019
    Configuration menu
    Copy the full SHA
    f4e4cdd View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2019

  1. grpc: gateway: return empty response on submission of improper form

    @mohammed90
    mohammed90 committed Jul 3, 2019
    Configuration menu
    Copy the full SHA
    543d135 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. grpc: remove leftover from the TLS logic

    @mohammed90
    mohammed90 committed Jul 5, 2019
    Configuration menu
    Copy the full SHA
    a92de9c View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. grpc: remove leftover logInterceptor

    @mohammed90
    mohammed90 committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    fc64cdd View commit details
    Browse the repository at this point in the history

  2. grpc: gateway: simplify FormWrapper middleware and make it more apt f… 

    …or our specific use case
    @mohammed90
    mohammed90 committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    8df8466 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2019

  1. Add Put method support to Client

    @mohammed90
    mohammed90 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    9a481d4 View commit details
    Browse the repository at this point in the history

  2. docs: correct status code of Begin OAuth request

    @mohammed90
    mohammed90 committed Jul 26, 2019
    Configuration menu
    Copy the full SHA
    7286746 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2019

  1. gateway: destutter

    @mohammed90
    mohammed90 committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    623fea4 View commit details
    Browse the repository at this point in the history

  2. gateway: include missing protobuf message types to the CookieSetter c… 

    …heck
    @mohammed90
    mohammed90 committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    3eaaf1d View commit details
    Browse the repository at this point in the history

  3. grpc: gateway: use WithBlock to block until client connection is ready

    @mohammed90
    mohammed90 committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    7d9089a View commit details
    Browse the repository at this point in the history

  4. grpc: maintain consistent capitalization and spelling of the WWW-Auth… 

    …enticate header
    @mohammed90
    mohammed90 committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    885d6ac View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2019

  1. grpc: gateway: add (semi-)comprehensive test for REST interface

    @mohammed90
    mohammed90 committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    a16ec61 View commit details
    Browse the repository at this point in the history

  2. grpc: be consistent in using ToStatusErrorWithDetails everywhere

    @mohammed90
    mohammed90 committed Aug 3, 2019
    Configuration menu
    Copy the full SHA
    6e8d34c View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. grpc: inject *grpc.UnaryServerInfo into request context to be availab… 

    …le for gRPC-related logging
    @mohammed90
    mohammed90 committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    ccbcf32 View commit details
    Browse the repository at this point in the history

  2. grpc: gateway: don't adjust the header at the gRPC middleware level i… 

    …n Basic-Auth failure cases. Returning an error is sufficient to signal the failure to gRPC clients, and the REST clients are authenticated at the HTTP middleware level.
    @mohammed90
    mohammed90 committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    1186ca2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2019

  1. grpc: gateway: set the proper value for audience based on Origin head… 

    …er; use the isser host (from URL) for gRPC requests
    @mohammed90
    mohammed90 committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    9312d36 View commit details
    Browse the repository at this point in the history

  2. grpc: unexport the session gRPC interceptor

    @mohammed90
    mohammed90 committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    f11fbe3 View commit details
    Browse the repository at this point in the history

  3. grpc: remove unused, leftover HTTP Basic Auth related variables

    @mohammed90
    mohammed90 committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    5952dfb View commit details
    Browse the repository at this point in the history

  4. grpc: gateway: remove superfluous colon in log message

    @mohammed90
    mohammed90 committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    419f7f6 View commit details
    Browse the repository at this point in the history

  5. grpc: re-arrange the funcs into different files while maintaining con… 

    …sistency of naming between private/ and public/ services
    @mohammed90
    mohammed90 committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    09d989b View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2019

  1. grpc: gateway: improve test logic of route registration

    @mohammed90
    mohammed90 committed Aug 17, 2019
    Configuration menu
    Copy the full SHA
    5371d3d View commit details
    Browse the repository at this point in the history

  2. grpc: gateway: unexport the route registration method for private routes

    @mohammed90
    mohammed90 committed Aug 17, 2019
    Configuration menu
    Copy the full SHA
    2ebc37c View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2019

  1. grpc: rewrite the recovery interceptor to resolve a bug

    @mohammed90
    mohammed90 committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    ce8e2d5 View commit details
    Browse the repository at this point in the history

  2. grpc: add comprehensive test for the gRPC interface

    @mohammed90
    mohammed90 committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    dbe77a0 View commit details
    Browse the repository at this point in the history

  3. tidy go.mod

    @mohammed90
    mohammed90 committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    e58a260 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into grpc-api

    @mohammed90
    mohammed90 committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    35cb27e View commit details
    Browse the repository at this point in the history

  5. grpc: adapt to changes from master

    @mohammed90
    mohammed90 committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    c658672 View commit details
    Browse the repository at this point in the history

  6. grpc: change port numbers used in test and hope for the best

    @mohammed90
    mohammed90 committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    657a709 View commit details
    Browse the repository at this point in the history

  7. grpc: test: make testing REST interface a subtest

    @mohammed90
    mohammed90 committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    1d8a205 View commit details
    Browse the repository at this point in the history

  8. grpc: test: go doesn't like it when we create new listeners in differ… 

    …ent tests, so make all the server tests under a single TestServer func and everything else a subtest
    @mohammed90
    mohammed90 committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    9d088ef View commit details
    Browse the repository at this point in the history

  9. increase test-ci timeout

    @mohammed90
    mohammed90 committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    0d73fe0 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2019

  1. grpc: remove envelopes from protobuf definitions; REST responses are … 

    …wrapped in custom forwarder
    @mohammed90
    mohammed90 committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    ae3067a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into grpc-api

    @mohammed90
    mohammed90 committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    aa215e0 View commit details
    Browse the repository at this point in the history

  3. pull upstream

    @mohammed90
    mohammed90 committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    7b98bbf View commit details
    Browse the repository at this point in the history

  4. grpc: adjust server test to new protobuf definitions

    @mohammed90
    mohammed90 committed Oct 5, 2019
    Configuration menu
    Copy the full SHA
    9d5026a View commit details
    Browse the repository at this point in the history