Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new public release - 1728491354 #3

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

uug-ai-bot
Copy link
Contributor

@uug-ai-bot uug-ai-bot commented Oct 9, 2024

Pull Request: A new public release - 1728491354

Motivation and Improvement

This pull request focuses on refining the configuration for our Helm chart, specifically the values.yaml file, to prepare for a new public release. The key motivations and improvements are as follows:

  1. Repository and Tag Updates:

    • Updated the repository and tags for various services to reflect the new public release. This ensures that the deployment uses the latest stable versions of our services (uugai/hub-api v1.0.4, uugai/hub-frontend v1.0.15, etc.).
  2. Code Clean-Up:

    • Removed unnecessary blank lines and commented sections to enhance the readability and maintainability of the values.yaml file. Clean and well-organized configuration files are easier to manage and reduce the likelihood of errors.
  3. Security and Best Practices:

    • Ensured that sensitive information such as tokens and passwords are clearly marked and recommended for change, promoting better security practices.

Summary of Changes

  • Repository and Tag Updates:

    • Updated kerberoshub.api.repository to uugai/hub-api and tag to v1.0.4.
    • Updated kerberoshub.frontend.repository to uugai/hub-frontend and tag to v1.0.15.
    • Updated kerberospipeline.notify.tag to 1.0.7688338979.
  • Removed Unnecessary Blank Lines:

    • Cleaned up redundant blank lines throughout the file to improve readability.
  • Commented Sections Adjustment:

    • Adjusted indentation and formatting for commented sections related to email templates and volume mounts to maintain consistency.

These changes will help streamline the deployment process, improve security, and ensure that the project remains maintainable and easy to understand. This contributes to a more robust and reliable release.

@cedricve
Copy link
Member

cedricve commented Oct 9, 2024

Let it fly!

@cedricve cedricve merged commit 90cf8a2 into main Oct 9, 2024
2 checks passed
@cedricve cedricve deleted the public-release-1728491349 branch October 9, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants