Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull Request Description
Title: Fix server response closing
Motivation and Context
The current implementation of the
Device
class assumes that the server response (servResp
) is always non-nil before attempting to close its body. However, in cases where an error occurs andservResp
is nil, callingservResp.Body.Close()
will result in a runtime panic, which can cause the application to crash unexpectedly.This pull request adds a nil check before attempting to close the server response body. This ensures that the connection is only reused if the server response is valid, thereby preventing potential runtime panics and improving the robustness of the code.
Changes Made
servResp
before callingservResp.Body.Close()
in thecallMethodDo
andSendSoap
methods.Device.go
file.Why This Improves the Project
servResp
is non-nil before attempting to close its body, we prevent potential runtime panics that could crash the application.Overall, this change contributes to the stability and reliability of the project, making it safer for production use.