-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Allow multiple names for vector indicators (#382) #980
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this looks good and is properly classified (bug). 😆
Hi @kernc, Thank you for the feedback! I think I addressed everything. Could you, please, resolve all conversations if it looks okay to you. Thank you:slightly_smiling_face: |
172767c
to
8211d1b
Compare
36cb215
to
f795570
Compare
Previously we only allowed one name per vector indicator: def _my_indicator(open, close): return tuple( _my_indicator_one(open, close), _my_indicator_two(open, close), ) self.I( _my_indicator, # One name is used to describe two values name="My Indicator", self.data.Open, self.data.Close ) Now, the user can supply two (or more) names to annotate each value individually. The names will be shown in the plot legend. The following is now valid: self.I( _my_indicator, # Two names can now be passed name=["My Indicator One", "My Indicator Two"], self.data.Open, self.data.Close ) Co-authored-by: kernc <[email protected]>
It is. The checks won't finish near green, though. Project docs build hinges on scikit-optimize being presently unmaintained and in a defunct state wrt other Python/numpy/sklearn stack. I'm not yet certain what to do about that. |
include the scikit-optimize, you actually need just a few files as far as I remember. |
Are there any obstacles that preventing merge of this?
I understand it's an issue, but I appreciate this will be addressed separately in another PR? |
Fixes #382
Closes #385
Previously we only allowed one name per vector indicator:
Now, the user can supply two (or more) names to annotate each value individually. The names will be shown in the plot legend. The following is now valid: