bpf, arm64: support for timed may_goto #9439
Open
+76
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: fa47913 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2a0e5cd to
2562e0e
Compare
|
Upstream branch: 9e293d4 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/989634=>bpf-next
branch
from
d7f1ccf to
5a3bc06
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2562e0e to
5583eb6
Compare
|
Upstream branch: 3e2b799 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/989634=>bpf-next
branch
from
5a3bc06 to
e9546d6
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
5583eb6 to
601ea2d
Compare
|
Upstream branch: c93c59b |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/989634=>bpf-next
branch
from
e9546d6 to
5782fc3
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
601ea2d to
7390c2c
Compare
|
Upstream branch: bf0c2a8 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/989634=>bpf-next
branch
from
5782fc3 to
fa25bf6
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
7390c2c to
3a736b5
Compare
|
Upstream branch: 2caa6b8 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/989634=>bpf-next
branch
from
fa25bf6 to
a27cd59
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
3a736b5 to
c210f22
Compare
|
Upstream branch: 0786654 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/989634=>bpf-next
branch
from
a27cd59 to
b229eb1
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
c210f22 to
2530e45
Compare
|
Upstream branch: dc0fe95 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/989634=>bpf-next
branch
from
b229eb1 to
65dffe3
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2530e45 to
61c9cef
Compare
|
Upstream branch: c80d797 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/989634=>bpf-next
branch
from
65dffe3 to
8cf6a6e
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
61c9cef to
715d6cb
Compare
|
Upstream branch: 3ec8560 |
When verifier sees a timed may_goto instruction, it emits a call to arch_bpf_timed_may_goto() with a stack offset in BPF_REG_AX (arm64 r9) and expects a count value to be returned in the same register. The verifier doesn't save or restore any registers before emitting this call. arch_bpf_timed_may_goto() should act as a trampoline to call bpf_check_timed_may_goto() with AAPCS64 calling convention. To support this custom calling convention, implement arch_bpf_timed_may_goto() in assembly and make sure BPF caller saved registers are saved and restored, call bpf_check_timed_may_goto with arm64 calling convention where first argument and return value both are in x0, then put the result back into BPF_REG_AX before returning. Signed-off-by: Puranjay Mohan <[email protected]>
As arm64 JIT now supports timed may_goto instruction, make sure all relevant tests run on this architecture. Some tests were enabled and other required modifications to work properly on arm64. $ ./test_progs -a "stream*","*may_goto*",verifier_bpf_fastcall #404 stream_errors:OK [...] #406/2 stream_success/stream_cond_break:OK [...] #494/23 verifier_bpf_fastcall/may_goto_interaction_x86_64:SKIP #494/24 verifier_bpf_fastcall/may_goto_interaction_arm64:OK [...] #539/1 verifier_may_goto_1/may_goto 0:OK #539/2 verifier_may_goto_1/batch 2 of may_goto 0:OK #539/3 verifier_may_goto_1/may_goto batch with offsets 2/1/0:OK #539/4 verifier_may_goto_1/may_goto batch with offsets 2/0:OK #539 verifier_may_goto_1:OK #540/1 verifier_may_goto_2/C code with may_goto 0:OK #540 verifier_may_goto_2:OK Summary: 7/16 PASSED, 25 SKIPPED, 0 FAILED Signed-off-by: Puranjay Mohan <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/989634=>bpf-next
branch
from
8cf6a6e to
d394b96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf, arm64: support for timed may_goto
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634