s390/bpf: Write back the tail call counter #9455
Closed
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: fa47913 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2a0e5cd to
2562e0e
Compare
|
Upstream branch: 9e293d4 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990598=>bpf-next
branch
from
010f224 to
66a8f99
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
2562e0e to
5583eb6
Compare
|
Upstream branch: 3e2b799 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990598=>bpf-next
branch
from
66a8f99 to
b8d3c0f
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
5583eb6 to
601ea2d
Compare
|
Upstream branch: c93c59b |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990598=>bpf-next
branch
from
b8d3c0f to
3216dc3
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
601ea2d to
7390c2c
Compare
|
Upstream branch: bf0c2a8 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990598=>bpf-next
branch
from
3216dc3 to
d361daf
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
7390c2c to
3a736b5
Compare
|
Upstream branch: 2caa6b8 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990598=>bpf-next
branch
from
d361daf to
3f1c563
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
3a736b5 to
c210f22
Compare
|
Upstream branch: 0786654 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990598=>bpf-next
branch
from
3f1c563 to
a7abd29
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
c210f22 to
2530e45
Compare
|
Upstream branch: dc0fe95 |
The tailcall_bpf2bpf_hierarchy_1 test hangs on s390. Its call graph is
as follows:
entry()
subprog_tail()
bpf_tail_call_static(0) -> entry + tail_call_start
subprog_tail()
bpf_tail_call_static(0) -> entry + tail_call_start
entry() copies its tail call counter to the subprog_tail()'s frame,
which then increments it. However, the incremented result is discarded,
leading to an astronomically large number of tail calls.
Fix by writing the incremented counter back to the entry()'s frame.
Fixes: dd691e8 ("s390/bpf: Implement bpf_jit_supports_subprog_tailcalls()")
Signed-off-by: Ilya Leoshkevich <[email protected]>
The tailcall_bpf2bpf_hierarchy_fentry test hangs on s390. Its call
graph is as follows:
entry()
subprog_tail()
trampoline()
fentry()
the rest of subprog_tail() # via BPF_TRAMP_F_CALL_ORIG
return to entry()
The problem is that the rest of subprog_tail() increments the tail call
counter, but the trampoline discards the incremented value. This
results in an astronomically large number of tail calls.
Fix by making the trampoline write the incremented tail call counter
back.
Fixes: 528eb2c ("s390/bpf: Implement arch_prepare_bpf_trampoline()")
Signed-off-by: Ilya Leoshkevich <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/990598=>bpf-next
branch
from
a7abd29 to
0931a02
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=990598 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: s390/bpf: Write back the tail call counter
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=990598