Feat: improve notifications code #1493
Merged
+17
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored notification conditions so that it only runs on production or dev environments instead of only on staging; - Removed now unecessary is_production_instance function; - Refactored getting email env vars in settings and added them to the example env; - Slightly increased the default timeout for both databases.
LucasSantos27
approved these changes
Sep 15, 2025
| @@ -202,7 +202,7 @@ def get_json_env_var(name, default): | |||
| "PASSWORD": "kernelci-db-password", | |||
| "HOST": "127.0.0.1", | |||
| "OPTIONS": { | |||
| "connect_timeout": 5, | |||
| "connect_timeout": 16, | |||
There was a problem hiding this comment.
its the DB_DEFAULT_TIMEOUT on entrypoint.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
How to test
The changes are mostly code-only, but you can test them by running the notifications command.