Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add http cache #242

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

loadez
Copy link
Collaborator

@loadez loadez commented Sep 5, 2024

Added http cache to all backend paths

@loadez loadez self-assigned this Sep 5, 2024
@loadez loadez force-pushed the feat/add-cache-to-queries-and-fix-count branch from 19cfb1c to c379479 Compare September 6, 2024 16:09
@loadez loadez changed the title feat: add cache to queries and fix test count feat: add http cache Sep 6, 2024
@loadez loadez marked this pull request as ready for review September 6, 2024 16:10
@loadez loadez force-pushed the feat/add-cache-to-queries-and-fix-count branch from c379479 to 36ecbab Compare September 6, 2024 19:38
Copy link
Collaborator

@WilsonNet WilsonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this but let's wait for after the demo

),
path("build/<str:build_id>", views.BuildDetails.as_view(), name="buildDetails"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather write this way:

path("tree/", cache_page(timeout)(views.TreeView.as_view()), 
    name="tree"),

In order to improve readability.
The rest is perfect!

@loadez loadez force-pushed the feat/add-cache-to-queries-and-fix-count branch from 36ecbab to 6bf22ae Compare September 13, 2024 19:10
@loadez loadez force-pushed the feat/add-cache-to-queries-and-fix-count branch from 6bf22ae to d9c9905 Compare September 13, 2024 19:51
@loadez loadez merged commit d9c9905 into main Sep 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants