feat/performance boots #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfjnascimento
force-pushed
the
feat/performance-boots
branch
from
a79a7a6
to
8ccfe99
Compare
Comment on lines
+129
to
+130
| const { data, status } = useBuildStatusCount( | ||
| { buildId: contentData.id ?? '' }, | ||
| { enabled: !!contentData.id }, | ||
| ); |
There was a problem hiding this comment.
useBuildStatusCount can receive only id and "calculate" enabled if
Comment on lines
+37
to
+45
| "build_id": build_status.id, | ||
| "fail_tests": build_status.fail_tests, | ||
| "error_tests": build_status.error_tests, | ||
| "miss_tests": build_status.miss_tests, | ||
| "pass_tests": build_status.pass_tests, | ||
| "done_tests": build_status.done_tests, | ||
| "skip_tests": build_status.skip_tests, | ||
| "null_tests": build_status.null_tests, | ||
| "total_tests": build_status.total_tests, |
There was a problem hiding this comment.
I would say that we should create a pattern and always use the same names for status (maybe use the same as KCIDB "MISS, PASS, DONE") in all our queries, but it's up to you whether to address this suggestion for this query now or latter.
There was a problem hiding this comment.
we can do that but we need to have some way to standardize beside our mouths, probably pydantic will serve for that purpose
loadez
approved these changes
Sep 12, 2024
WilsonNet
force-pushed
the
feat/performance-boots
branch
from
8ccfe99
to
bce175e
Compare
- Added a new endpoint to fetch build status counts - Created `BuildStatusCountView` in `views/buildStatusCountView.py` - Updated `urls.py` to include the new endpoint - Modified `TreeDetails.tsx` to use the new endpoint - Updated `Accordion` component to display build status counts - Refactored `TreeDetails` related types and hooks
WilsonNet
force-pushed
the
feat/performance-boots
branch
from
bce175e
to
8610500
Compare
Added a new script to fetch the build status count from the API. This script sends an HTTP GET request to the specified endpoint and includes sample response headers and JSON data for reference. The script will help in monitoring the build status and integrating with other tools for continuous integration and deployment processes.
WilsonNet
force-pushed
the
feat/performance-boots
branch
from
8610500
to
d2440fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR remove the precounts of the status for each builds and put it under demand when the user opens an accordion
You can test the graphs in this link:
http://localhost:5173/tree/034835342aab1cc7dc1733a98cd2a6d159ee242a?tableFilter=%7B%22bootsTable%22%3A%22all%22%2C%22buildsTable%22%3A%22all%22%2C%22testsTable%22%3A%22all%22%7D&origin=maestro¤tTreeDetailsTab=treeDetails.builds&diffFilter=%7B%7D&treeInfo=%7B%22gitUrl%22%3A%22https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Famlogic%2Flinux.git%22%2C%22gitBranch%22%3A%22for-next%22%2C%22treeName%22%3A%22amlogic%22%2C%22commitName%22%3A%22v6.11-rc1-22-g034835342aab%22%2C%22headCommitHash%22%3A%22034835342aab1cc7dc1733a98cd2a6d159ee242a%22%7D
And the slow repo in this link:
http://localhost:5173/tree/fe3b83691989077c55cd1e91e0a0bd831b6255aa?tableFilter=%7B%22bootsTable%22%3A%22all%22%2C%22buildsTable%22%3A%22all%22%2C%22testsTable%22%3A%22all%22%7D&origin=maestro¤tTreeDetailsTab=treeDetails.builds&diffFilter=%7B%7D&treeInfo=%7B%22gitUrl%22%3A%22https%3A%2F%2Fgit.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-next.git%22%2C%22gitBranch%22%3A%22pending-fixes%22%2C%22treeName%22%3A%22next%22%2C%22commitName%22%3A%22v6.11-rc7-98-gfe3b83691989%22%2C%22headCommitHash%22%3A%22fe3b83691989077c55cd1e91e0a0bd831b6255aa%22%7D